Strange issue with Rietveld and TypeSerializer. Maybe this second upload
will be better.


http://gwt-code-reviews.appspot.com/1310807/diff/1/2
File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
(right):

http://gwt-code-reviews.appspot.com/1310807/diff/1/2#newcode39
user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:39:
private static final int INITIAL_CAPACITY = 16;
On 2011/02/04 22:28:41, jbrosenberg wrote:
Should be 'LOAD_FACTOR'

Weird. I remember fixing this exact problem. It may have been the victim
of an untimely IDE crash.

http://gwt-code-reviews.appspot.com/1310807/diff/1/2#newcode58
user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:58:
On 2011/02/04 22:28:41, jbrosenberg wrote:
There are 2 getField() methods, one returns the Field itself, the
other returns
the Object value of the field.  Can we differentiate the names of
these 2?
Perhaps have:
getField & getFieldValue (and also change setField to setFieldValue).


Oh wow. Ditto here. I had changed this to findField, and so I do again.

http://gwt-code-reviews.appspot.com/1310807/diff/1/3
File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
(right):

http://gwt-code-reviews.appspot.com/1310807/diff/1/3#newcode44
user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java:44:
/**
On 2011/02/04 22:28:41, jbrosenberg wrote:
Can you add some comments explaining the reason for, and the
differences
between, the prod and dev mode paths?

Done.

http://gwt-code-reviews.appspot.com/1310807/diff/1/5
File
user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
(right):

http://gwt-code-reviews.appspot.com/1310807/diff/1/5#newcode26
user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:26:

On 2011/02/04 22:28:41, jbrosenberg wrote:
Rename this (if it's also to be renamed in the non super source
version (e.g.
getFieldValue())

Not renamed.

http://gwt-code-reviews.appspot.com/1310807/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to