LGTM, with nits

http://gwt-code-reviews.appspot.com/1343801/diff/1/8
File user/src/com/google/gwt/validation/rebind/Util.java (right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93
user/src/com/google/gwt/validation/rebind/Util.java:93: * @return
Remove empty tags

http://gwt-code-reviews.appspot.com/1343801/diff/1/12
File
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/12#newcode46
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java:46:
fail("This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.");
Issie -> Issue

http://gwt-code-reviews.appspot.com/1343801/diff/1/12#newcode52
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java:52:
fail("This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.");
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/13
File
user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/13#newcode36
user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorGwtTest.java:36:
fail("This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.");
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/14
File
user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/14#newcode40
user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionGwtTest.java:40:
fail("This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.");
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/17
File
user/test/org/hibernate/jsr303/tck/tests/validation/ValidatePropertyGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/17#newcode52
user/test/org/hibernate/jsr303/tck/tests/validation/ValidatePropertyGwtTest.java:52:
fail("This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.");
Idem

http://gwt-code-reviews.appspot.com/1343801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to