LGTM



http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004
File dev/core/src/com/google/gwt/core/ext/soyc/Member.java (left):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004#oldcode44
dev/core/src/com/google/gwt/core/ext/soyc/Member.java:44:
Hypothetically, would the soyc-generator be able to get this info from
the symbolMaps file anyway?

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2019
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(left):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2019#oldcode963
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:963:
SourceInfo sourceInfo = program.createSourceInfoSynthetic(
A little unfortunate, since it is nice to be able to track how big the
bootstrap or stats stuff is. If we used separate token class literals
like JavaToJavaScriptCompiler.BootStrap.class, it might restore some
ability to disambiguate these synthetics.

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2024
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2024#newcode588
dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java:588: // and line
number.
Interesting idea, although there might be some overhead from
throwing/catching a large number of exceptions. A quicker hack is to
just require unique tokens, e.g. interface FooSourceLocation{}

http://gwt-code-reviews.appspot.com/1345801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to