I will let Scott have the final word. Tests look good. Just a nit on on exposing a public setter for the value of JSO.
http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode159 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:159: jsoClassName = className; This worries me a little bit :). Can we make this protected or package protected? http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode941 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:941: whitespace http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java File dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java (right): http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode648 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:648: }; insert newline http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode660 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:660: }; newline http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode669 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:669: }; newline http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode678 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:678: }; newline http://gwt-code-reviews.appspot.com/1369805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
