http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java File dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java (right):
http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode34 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:34: /* On 2011/03/04 16:20:54, scottb wrote:
LG, but it might be better to move this to JavaCompilationSuite since
most of
the tests in that suite have the same issue.
Added it there, but wouldn't it be best to also leave it in JSORestrictionsTest in case you run the test case standalone? http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode96 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:96: System.err.print(goodCode.toString()); On 2011/03/04 16:20:54, scottb wrote:
Debug statement
oops http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode193 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:193: .append(" public static class CommonBase extends JavaScriptObject implements CommonInterface {\n"); On 2011/03/04 16:20:54, scottb wrote:
Style nit: probably better to break the string literals sooner than
have to
break the outer formatting.
Done. http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode207 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:207: System.err.print(goodCode.toString()); On 2011/03/04 16:20:54, scottb wrote:
Debug statement
Done. http://gwt-code-reviews.appspot.com/1369805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
