LGTM, I have no substantive comments, go forth and code some more.

I was asking myself if the stack approach might increase memory
requirements, but the entire tree must already be in memory, so I
stopped worrying about it.


http://gwt-code-reviews.appspot.com/1373805/diff/6001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1373805/diff/6001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode1595
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:1595: // SEE
NOTE ON JDT FORCED OPTIMIZATIONS
I think I understand what's going on, but I don't see the note anywhere.

http://gwt-code-reviews.appspot.com/1373805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to