LGTM. It is strange that the pattern has to match the whole string. I
would have expected for the developer to be in control of that by using
"^" and "$" as needed.


http://gwt-code-reviews.appspot.com/1378801/diff/1/user/src/com/google/gwt/validation/client/constraints/PatternValidator.java
File
user/src/com/google/gwt/validation/client/constraints/PatternValidator.java
(right):

http://gwt-code-reviews.appspot.com/1378801/diff/1/user/src/com/google/gwt/validation/client/constraints/PatternValidator.java#newcode53
user/src/com/google/gwt/validation/client/constraints/PatternValidator.java:53:
return match.getGroup(0).equals(value);
Would it be faster but still correct to compare the lengths?

http://gwt-code-reviews.appspot.com/1378801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to