John L will need to give the real review, but one nit:


http://gwt-code-reviews.appspot.com/1383801/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
(right):

http://gwt-code-reviews.appspot.com/1383801/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java#newcode163
dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:163: if
(minCostRuleSoFar.getFallbackEvaluationCost() < Integer.MAX_VALUE) {
Should tell them what you could not find an exact match for, right?
Looks like this would print out IE8, but how will they know that IE9 is
the problem, and that user.agent is what you're trying to resolve?

http://gwt-code-reviews.appspot.com/1383801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to