LGTM

http://gwt-code-reviews.appspot.com/1385801/diff/1010/dev/core/src/com/google/gwt/core/ext/linker/impl/computeUrlForResource.js
File
dev/core/src/com/google/gwt/core/ext/linker/impl/computeUrlForResource.js
(right):

http://gwt-code-reviews.appspot.com/1385801/diff/1010/dev/core/src/com/google/gwt/core/ext/linker/impl/computeUrlForResource.js#newcode24
dev/core/src/com/google/gwt/core/ext/linker/impl/computeUrlForResource.js:24:
if (resource.match(/^\//)) {
On 2011/03/11 20:03:16, zundel wrote:
I could have used resources.substr() here.  Any preference?

To be honest, I don't know about the tradeoffs.  In general, this should
happen only a few times per page and each stylesheet fetched has a huge
amount of overhead already compared to this (since it involves a
resource fetch), so I think either is fine.

http://gwt-code-reviews.appspot.com/1385801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to