Thanks, it is really nice for Eclipse testing.

On Fri, Mar 25, 2011 at 9:56 PM, Eric Ayers <zun...@google.com> wrote:

> LGTM
>
> I didn't think maintaining this suite was a priority - the ant build
> searches for *Test.java and ignores the suite.  I guess if you are
> manually testing from eclipse its useful.
>
> On Fri, Mar 25, 2011 at 8:10 PM,  <sco...@google.com> wrote:
> > Reviewers: zundel,
> >
> >
> >
> > Please review this at http://gwt-code-reviews.appspot.com/1385808/
> >
> > Affected files:
> >  M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> >
> >
> > Index: dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> > diff --git
> > a/dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> > b/dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> > index
> >
> dc61d2436d7d032cf05b6a88bbbd22b59d7a53f8..40730954464cc12237d9a293d4454582f0a5f20c
> > 100644
> > --- a/dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> > +++ b/dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java
> > @@ -42,15 +42,20 @@ public class JavaCompilationSuite {
> >
> >     suite.addTestSuite(ArtificialRescueCheckerTest.class);
> >     suite.addTestSuite(BinaryTypeReferenceRestrictionsCheckerTest.class);
> > +    suite.addTestSuite(BytecodeSignatureMakerTest.class);
> >     suite.addTestSuite(CompilationStateTest.class);
> >     suite.addTestSuite(CompilationUnitFileReferenceTest.class);
> > +    suite.addTestSuite(CompiledClassTest.class);
> >     suite.addTestSuite(GWTProblemTest.class);
> >     suite.addTestSuite(JavaSourceParserTest.class);
> >     suite.addTestSuite(JdtBehaviorTest.class);
> >     suite.addTestSuite(JdtCompilerTest.class);
> > -    suite.addTestSuite(JSORestrictionsTest.class);
> >     suite.addTestSuite(JsniCheckerTest.class);
> >     suite.addTestSuite(JsniCollectorTest.class);
> > +    suite.addTestSuite(JSORestrictionsTest.class);
> > +    suite.addTestSuite(MemoryUnitCacheTest.class);
> > +    suite.addTestSuite(PersistentUnitCacheTest.class);
> > +    suite.addTestSuite(TypeOracleMediatorFromByteCodeTest.class);
> >     suite.addTestSuite(TypeOracleMediatorFromSourceTest.class);
> >
> >     suite.addTestSuite(CollectClassDataTest.class);
> >
> >
> >
>
>
>
> --
> Eric Z. Ayers
> Google Web Toolkit, Atlanta, GA USA
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to