Reviewers: pdr,
Description:
New projects should always have a DTD specified in their template
.gwt.xml module file
Also, fix broken NoNag version check logic.
Please review this at http://gwt-code-reviews.appspot.com/1407803/
Affected files:
M user/src/com/google/gwt/user/tools/WebAppCreator.java
Index: user/src/com/google/gwt/user/tools/WebAppCreator.java
===================================================================
--- user/src/com/google/gwt/user/tools/WebAppCreator.java (revision 9955)
+++ user/src/com/google/gwt/user/tools/WebAppCreator.java (working copy)
@@ -459,9 +459,13 @@
String gwtValidationSourcesPath = installPath + '/'
+ "validation-api-1.0.0.GA-sources.jar";
// Public builds generate a DTD reference.
- String gwtModuleDtd = "";
+ String gwtModuleDtd = "\n<!-- Using DTD from SVN 'trunk'. You probably
want to change this to a specific, release tagged, DTD -->"
+ + "\n<!DOCTYPE module PUBLIC \"-//Google Inc.//DTD Google Web
Toolkit "
+ + About.getGwtVersionNum()
+ + "//EN\" \"http://google-web-toolkit.googlecode.com/svn/trunk/";
+ + "/distro-source/core/src/gwt-module.dtd\">";
GwtVersion gwtVersion = About.getGwtVersionObject();
- if (gwtVersion.isNoNagVersion()) {
+ if (!gwtVersion.isNoNagVersion() && !gwtVersion.equals(new
GwtVersion(null))) {
gwtModuleDtd = "\n<!DOCTYPE module PUBLIC \"-//Google Inc.//DTD
Google Web Toolkit "
+ About.getGwtVersionNum()
+ "//EN\" \"http://google-web-toolkit.googlecode.com/svn/tags/";
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
