LGTM
http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java File user/src/com/google/gwt/media/client/Video.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java#newcode88 user/src/com/google/gwt/media/client/Video.java:88: return (VideoElement) getMediaElement(); It might, but more importantly I think that casts leave you open to runtime type errors that could otherwise be detected at compile time. Doesn't really matter in this case, but I try to avoid casts as a habit. On 2011/04/13 18:11:17, pdr wrote:
On 2011/04/13 17:46:08, jlabanca wrote: > I liked cast() better than a cast if it works.
Done (curious, why? Does it save a cast check?)
http://gwt-code-reviews.appspot.com/1415801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
