http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java (left):
http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#oldcode74 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:74: if (Util.findSourceInClassPath(cl, missingType) == null) { On 2011/04/13 19:20:43, zundel wrote:
this didn't make any sense to me - didn't the code above just check to
to see if
sourceURL was null?
Looks redundant to me. http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java (right): http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode206 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:206: String topLevelType = typeName.replaceAll("\\$.*$", ""); The use of "$'s" for nested types is just naming convention. For example, I can name a top-level class "Foo$", without any problems. You don't want to have to linear-scan over the unitMap to find the matching CompilationUnit, so you should probably build an index from all types (including nested) to CompilationUnits. http://gwt-code-reviews.appspot.com/1416801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
