LGTM

On Fri, Apr 15, 2011 at 9:11 AM, <[email protected]> wrote:

> Reviewers: rchandia,
>
> Description:
> Fixing a bug in CellTree where the Show More button doesn't work for the
> root node.
>
> Issue: 5547
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1420801/
>
> Affected files:
>  M user/src/com/google/gwt/user/cellview/client/CellTree.java
>
>
> Index: user/src/com/google/gwt/user/cellview/client/CellTree.java
> ===================================================================
> --- user/src/com/google/gwt/user/cellview/client/CellTree.java  (revision
> 9995)
> +++ user/src/com/google/gwt/user/cellview/client/CellTree.java  (working
> copy)
> @@ -682,7 +682,7 @@
>     final boolean isMouseDown = "mousedown".equals(eventType);
>     final boolean isClick = "click".equals(eventType);
>     final CellTreeNodeView<?> nodeView = findItemByChain(chain, 0,
> rootNode);
> -    if (nodeView != null && nodeView != rootNode) {
> +    if (nodeView != null) {
>       if (isMouseDown) {
>         Element showMoreElem = nodeView.getShowMoreElement();
>         if (nodeView.getImageElement().isOrHasChild(target)) {
> @@ -697,7 +697,7 @@
>       }
>
>       // Forward the event to the cell
> -      if (nodeView.getSelectionElement().isOrHasChild(target)) {
> +      if (nodeView != rootNode &&
> nodeView.getSelectionElement().isOrHasChild(target)) {
>         // Move the keyboard focus to the clicked item.
>         if (isClick) {
>           /*
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to