http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/src/com/google/gwt/user/rebind/rpc/Shared.java:56: private static SerializeFinalFieldsOptions serializeFinalFieldsValue; On 2011/04/18 14:18:10, bobv wrote:
See comment in previous revision. Static fields in Generator types
can cause
flaky behavior.
Agree. However, if I make the value non-static, then a lot of changes should be made in the legacy. We may keep it static for now. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode100 user/src/com/google/gwt/user/rebind/rpc/Shared.java:100: propertyOracle, RPC_PROP_SERIALIZE_FINAL_FIELDS, "FALSE").toUpperCase(); On 2011/04/18 14:18:10, bobv wrote:
You can use Enum.valueOf() instead of the if block below.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode56 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:56: private FinalFieldsTestServiceAsync finalFieldsTestService; On 2011/04/18 14:18:10, bobv wrote:
Member sort order. Fields should be defined before methods.
Done. Also did in FinalFieldsTestFalseNoWarn.java http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java#newcode27 user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java:27: public class FinalFieldsNode implements IsSerializable { On 2011/04/18 14:18:10, bobv wrote:
Use Serializable instead of IsSerializable.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java File user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java#newcode28 user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java:28: public FinalFieldsNode transferObject(FinalFieldsNode node) { On 2011/04/18 14:18:10, bobv wrote:
Check the incoming values in node to make sure that final fields are
being set
properly when sent by the client.
Done. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
