Both comments are somewhat related and reflect my phobia of big CLs. I'll address them still today. Thanks.
http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode97 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:97: public void addAttachStatement(String fieldName, String format, Object... args) On 2011/04/20 17:12:21, rjrjr wrote:
Better, but, my point is that all of these methods are redundant with
the
FieldWriter api. required should be public and these methods should be
inlined. Make sense, I was afraid that these methods were being called by other files which is totally stupid since they are new. I'll fix this. http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode332 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:332: // change in several files. On 2011/04/20 17:12:21, rjrjr wrote:
Sorry, not okay, this is a really common fail path and you're
destroying our
error reporting. Yes, I know it's behind the switch, but still.
Just throw the exception and let your IDE show you where to add the
throws
lines. It really won't take that long.
No problem at all, I'll have to add new files that must protect their methods with throws, so the CL should grow a little bit. Mechanical work, not a real issue. http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
