LGTM w/ nits
http://gwt-code-reviews.appspot.com/1423809/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java (right): http://gwt-code-reviews.appspot.com/1423809/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java#newcode810 dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:810: toRemove = Lists.add(toRemove,index); Why not do the remove inline? I think there's a fairly common pattern where you just index-- at the removal site to offset the ++ below. http://gwt-code-reviews.appspot.com/1423809/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java (right): http://gwt-code-reviews.appspot.com/1423809/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java#newcode250 dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java:250: } If I'm scanning this correctly, I think the sort order is backwards. http://gwt-code-reviews.appspot.com/1423809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
