http://gwt-code-reviews.appspot.com/1420809/diff/5001/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right):
http://gwt-code-reviews.appspot.com/1420809/diff/5001/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java#newcode464 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:464: Map<String, Object> values = Maps.newHashMap(annotData.getValues()); Okay, gotcha. Please add a comment "Make a copy before we mutate the collection". Also, please just use new HashMap() to follow the existing GWT style. If we think there's unique value in heavily utilizing guava for this, that should be a larger discussion. http://gwt-code-reviews.appspot.com/1420809/diff/5001/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java#newcode626 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:626: private CollectClassData processClass(TypeData typeData) { +1 http://gwt-code-reviews.appspot.com/1420809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
