http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml
File samples/mobilewebapp/build.xml (left):

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml#oldcode12
samples/mobilewebapp/build.xml:12: <include
name="javax/validation/validation-api-1.0.0.GA-sources.jar" />
Actually this validation jar entry is not used. My bad.

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml
File samples/mobilewebapp/build.xml (right):

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml#newcode16
samples/mobilewebapp/build.xml:16: <include
name="slf4j/slf4j-log4j12/slf4j-log4j12-1.6.1.jar" />
These entries do not seem to have an effect on the build. Probably
because MobileWebApp sample is being compiled as "source" so no libs are
ever copied.

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java#newcode113
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java:113:
@Override
This fails to compile with ant. It is because user-build.xml is using
Java 1.5 bytecode generation. We are deprecating Java 1.5 (and this is
an AppEngine app, after all) so it would be best to modify
user-build.xml to use Java 1.6.

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java#newcode125
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java:125:
}
Can we make failures more user friendly? Handle failure, advise of
problem, navigate to Task List place

http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java#newcode166
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java:166:
}
onFailure()?

http://gwt-code-reviews.appspot.com/1425808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to