Thanks, Ray. Submitting via SQ

http://gwt-code-reviews.appspot.com/1422813/diff/1/user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java
File
user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java
(right):

http://gwt-code-reviews.appspot.com/1422813/diff/1/user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java#newcode88
user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java:88:
// We must guarantee that child fields are built before the container.
On 2011/04/27 23:14:53, rjrjr wrote:
This comment doesn't really mean anything now, does it?

Done.

http://gwt-code-reviews.appspot.com/1422813/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

http://gwt-code-reviews.appspot.com/1422813/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode328
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:328:
FieldWriter parent = parsedFieldStack.getFirst();
On 2011/04/27 23:14:53, rjrjr wrote:
Would you mind wrapping parsedFieldStack.getFirst() in a private
peek() method?

Sure, no problem.

http://gwt-code-reviews.appspot.com/1422813/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to