http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java File dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java (left):
http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java#oldcode1 dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java:1: /* 2011 http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java File dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java (right): http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode81 dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:81: private JType originalReturnType; Consider changing this variable name to directOverride (see notes below for getOverrides method) http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode282 dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:282: /** s/method overrides/method directly overrides/ http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode284 dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:284: */ change name to something like setDirectOverride(JMethod directOverride) http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java (right): http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode794 dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:794: * } did you mean for Bar to extend Foo here? http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java (right): http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java#newcode804 dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:804: Update, in light of changes in other EnumOrdinalizer cleanup patch. This probably needs to end up in TypeRemapper. (but you already knew all this). http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java (right): http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java#newcode127 dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java:127: /** s/overriden/overridden/ http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java#newcode208 dev/core/src/com/google/gwt/dev/jjs/impl/Finalizer.java:208: update spelling of this variable to: isOverridden http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java (right): http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java#newcode2237 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java:2237: assert method.canBePolymorphic(); line wrap? http://gwt-code-reviews.appspot.com/1422810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
