Revision: 10115
Author: ncha...@google.com
Date: Fri Apr 29 07:05:45 2011
Log: Correctly handle graph navigation determinism.
[JSR 303 TCK Result] 122 of 257 (47.47%) Pass with 10 Failures and 7 Errors.
Review at http://gwt-code-reviews.appspot.com/1420812
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10115
Modified:
/trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/ValidateGwtTest.java
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationGwtTest.java
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java
=======================================
---
/trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java
Thu Mar 10 05:54:28 2011
+++
/trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java
Fri Apr 29 07:05:45 2011
@@ -62,7 +62,7 @@
this.beanDescriptor = beanDescriptor;
this.messageInterpolator = messageInterpolator;
this.validator = validator;
- this.validatedObjects = validatedObjects;
+ this.validatedObjects = new HashSet<Object>(validatedObjects);
}
public final void addValidatedObject(Object o) {
=======================================
---
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
Tue Apr 26 08:02:24 2011
+++
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
Fri Apr 29 07:05:45 2011
@@ -1483,7 +1483,7 @@
sw.println("\");");
// TODO(nchalko) move this out of here to the Validate method
- if (p.isCascaded()) {
+ if (p.isCascaded() && hasValid(p, useField)) {
// if(value != null) {
sw.println("if(value != null) {");
=======================================
---
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/ValidateGwtTest.java
Fri Mar 18 07:52:29 2011
+++
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/ValidateGwtTest.java
Fri Apr 29 07:05:45 2011
@@ -15,8 +15,6 @@
*/
package org.hibernate.jsr303.tck.tests.validation;
-import org.hibernate.jsr303.tck.util.client.Failing;
-
import javax.validation.ValidationException;
/**
@@ -34,12 +32,10 @@
delegate.testConstraintViolation();
}
- @Failing(issue = 5930)
public void testGraphValidationWithArray() {
delegate.testGraphValidationWithArray();
}
- @Failing(issue = 5930)
public void testGraphValidationWithList() {
delegate.testGraphValidationWithList();
}
=======================================
---
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationGwtTest.java
Wed Mar 2 06:32:23 2011
+++
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationGwtTest.java
Fri Apr 29 07:05:45 2011
@@ -48,7 +48,6 @@
delegate.testFullGraphValidationBeforeNextGroupInSequence();
}
- @Failing(issue = 5946)
public void testGraphNavigationDeterminism() {
delegate.testGraphNavigationDeterminism();
}
=======================================
---
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java
Mon Feb 28 07:12:19 2011
+++
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java
Fri Apr 29 07:05:45 2011
@@ -1,12 +1,12 @@
/*
* Copyright 2010 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the "License"); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -32,8 +32,8 @@
*/
@GwtValidation(value = {
AnimalCaretaker.class, Condor.class, Elephant.class,
GameReserve.class,
- MultiCage.class, MultiCage.class, Parent.class, SingleCage.class,
- User.class, Zebra.class, Zoo.class})
+ MultiCage.class, MultiCage.class, Order.class, Parent.class,
+ SingleCage.class, User.class, Zebra.class, Zoo.class})
public static interface GwtValidator extends Validator {
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
