http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right):
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode61 user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:61: private MortalLogger logger; On 2011/05/02 17:19:59, rjrjr wrote:
please make the logger final while you're here
Done. http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode62 user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:62: private FieldWriterType fieldType; On 2011/05/02 17:19:59, rjrjr wrote:
Shouldn't fieldType be final?
Nop, see setFieldType(). http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java File user/src/com/google/gwt/uibinder/rebind/FieldWriter.java (right): http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java#newcode145 user/src/com/google/gwt/uibinder/rebind/FieldWriter.java:145: void setFieldType(FieldWriterType type); On 2011/05/02 17:19:59, rjrjr wrote:
Seems wrong for this to be a mutable value.
True, done. http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java (right): http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java#newcode22 user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java:22: public enum FieldWriterType { On 2011/05/02 17:19:59, rjrjr wrote:
Does it need to be public?
Nop, done. http://gwt-code-reviews.appspot.com/1428807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
