http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java File dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java (right):
http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode17 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:17: On 2011/05/04 15:07:33, pdr wrote:
This linker should be defined in a gwt.xml file somewhere
Done. It seems I missed that change in the shuffle of splitting the original change in two. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode39 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:39: * <li>Add a mime-mapping to your web.xml file (this is for AppEngine, adjust On 2011/05/04 15:56:54, tobyr wrote:
The sample XML below looks standard to me. Why are we mentioning App
Engine? Done. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode49 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:49: * On 2011/05/04 14:59:48, jlabanca wrote:
Add <p> before each paragraph
Done. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode55 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:55: * and overrides {@code otherCAchedFiles()}, and use it as a linker instead: On 2011/05/04 14:59:48, jlabanca wrote:
/r/otherCAchedFiles/otherCachedFiles
You might mention that wildcards, such as /audio/*, will work (I think
thats
true).
I could not find that in http://dev.w3.org/html5/spec/offline.html#offline There is a wildcard for online resources, though. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode55 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:55: * and overrides {@code otherCAchedFiles()}, and use it as a linker instead: On 2011/05/04 15:07:33, pdr wrote:
otherCAchedFiles -> otherCachedFiles
Done. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode68 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:68: public class SimpleAppCacheLinker extends AbstractLinker { On 2011/05/04 14:59:48, jlabanca wrote:
I didn't see a rule in a gwt.xml file.
Done. It seems I got that change misplaced when I split the original patch in two. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode102 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:102: protected String[] otherCachedFiles() { On 2011/05/04 14:59:48, jlabanca wrote:
This is fine for now, but it would be nice if users could specify
other cached
files in a gwt.xml or appcache.manifest file instead of overriding
this class. Agreed. http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode166 dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:166: // build cache list On 2011/05/04 15:07:33, pdr wrote:
This code is essentially a duplicate of the above code. Break it out
into a
method?
Done. http://gwt-code-reviews.appspot.com/1428811/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java File samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java (right): http://gwt-code-reviews.appspot.com/1428811/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode37 samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:37: "/audio/error.wav" On 2011/05/04 14:59:48, jlabanca wrote:
also add: video/tutorial.mp4 video/tutorial.ogv
Done. http://gwt-code-reviews.appspot.com/1428811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
