[gwt-contrib] Re: AttachableHTMLPanel.logicalAdd() should receive an Attachable instead of a Widget. (issue1434802)

[rdcastro]

Thanks, Ray. Another look?


http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
(right):

http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java#newcode160
user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java:160: *
panel's element.
On 2011/05/05 21:51:15, rjrjr wrote:

No-op if called with an Attachable that isn't also IsWidget, but safe

to call

with such as a convenience.

Done.

http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java#newcode163
user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java:163: if
(!(attachable instanceof Widget)) {
On 2011/05/05 21:51:15, rjrjr wrote:

instanceof IsWidget

Done.

http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java#newcode167
user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java:167:
Widget widget = (Widget) attachable;
On 2011/05/05 21:51:15, rjrjr wrote:

((IsWidget)attachable).asWidget();

Done.

http://gwt-code-reviews.appspot.com/1434802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors