LGTM. With doc-nits.

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java
File
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java
(right):

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java#newcode51
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java:51:
* @return the local {@link Storage} object, or null unsupporting
browsers
...null on unsupporting...

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
File
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
(right):

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java#newcode205
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java:205:
* @param clientFactory the {@link ClientFactory} of shared resources
No longer a single param

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
File
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
(right):

http://gwt-code-reviews.appspot.com/1433801/diff/4003/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java#newcode109
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java:109:
* @param clientFactory the {@link ClientFactory} of shared resources
No longer a single param

http://gwt-code-reviews.appspot.com/1433801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to