Hmmm - that link doesn't work for me - did this issue get reverted? On Wed, May 11, 2011 at 1:02 PM, <schen...@google.com> wrote:
> Reviewers: unnurg, > > Description: > Removing the recently added RPC test for LogRecord, as it seems to > cause more problems than it is worth. > > > Please review this at http://gwt-code-reviews.appspot.com/1447803/ > > Affected files: > M user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java > > > Index: user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java > =================================================================== > --- user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java (revision > 10174) > +++ user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java (working > copy) > @@ -122,7 +122,13 @@ > > private CoreJavaTestServiceAsync coreJavaTestService; > > - public void testLogRecord() { > + /** > + * This test is disabled because the creation of java.util.logging.Level > + * objects fails in production mode with the standard logging behavior > of > + * tests. Given that we log things regularly, and hence get plenty of > + * implicit testing, it is not worth fixing the flakiness. > + */ > + public void disableTestLogRecord() { > CoreJavaTestServiceAsync service = getServiceAsync(); > delayTestFinishForRpc(); > service.echoLogRecord(expectedLogRecord, new AsyncCallback<LogRecord>() > { > > > -- DO NOT FORWARD -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
