LGTM On Mon, May 16, 2011 at 9:47 PM, <sco...@google.com> wrote: > There's no expected net change in behavior, it's just code cleanup. > > > http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java > File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java > (right): > > http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode2074 > dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:2074: > > On 2011/05/17 01:19:18, jbrosenberg wrote: >> >> white space above? > >> Is this still the correct positioning for this comment? Add something > > also >> >> about Array/Object > > I think the comment is set off ok, because it's meant to really refer to > the entire section below. The biggest reason for all this is that we > modify the JavaScript String prototype. We do not modify the JavaScript > Object or Array prototypes. I could probably be more clear here. > > http://gwt-code-reviews.appspot.com/1436801/ >
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
