[gwt-contrib] [google-web-toolkit] r10195 committed - Fix some warnings.

[codesite-noreply]

Revision: 10195
Author:   rj...@google.com
Date:     Thu May 19 03:45:45 2011
Log:      Fix some warnings.
http://code.google.com/p/google-web-toolkit/source/detail?r=10195

Added:
 /trunk/user/src/com/google/gwt/cell/client/ImageResourceRenderer.java
Modified:
 /trunk/user/src/com/google/gwt/cell/client/ImageResourceCell.java

=======================================
--- /dev/null
+++ /trunk/user/src/com/google/gwt/cell/client/ImageResourceRenderer.java	 
Thu May 19 03:45:45 2011
@@ -0,0 +1,32 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under
+ * the License.
+ */
+package com.google.gwt.cell.client;
+
+import com.google.gwt.resources.client.ImageResource;
+import com.google.gwt.safehtml.shared.SafeHtml;
+import com.google.gwt.safehtml.shared.SafeHtmlUtils;
+import com.google.gwt.text.shared.AbstractSafeHtmlRenderer;
+import com.google.gwt.user.client.ui.AbstractImagePrototype;
+
+/**
+ * Given an {@link ImageResource}, renders a span element to show it.
+ */
+public class ImageResourceRenderer extends  
AbstractSafeHtmlRenderer<ImageResource> {
+  @Override
+  public SafeHtml render(ImageResource image) {
+    return  
SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(image).getHTML());
+  }
+}
=======================================
--- /trunk/user/src/com/google/gwt/cell/client/ImageResourceCell.java	Wed  
Dec  1 05:40:20 2010
+++ /trunk/user/src/com/google/gwt/cell/client/ImageResourceCell.java	Thu  
May 19 03:45:45 2011
@@ -16,10 +16,7 @@
 package com.google.gwt.cell.client;

 import com.google.gwt.resources.client.ImageResource;
-import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
-import com.google.gwt.safehtml.shared.SafeHtmlUtils;
-import com.google.gwt.user.client.ui.AbstractImagePrototype;

 /**
  * An {@link AbstractCell} used to render an {@link ImageResource}.
@@ -32,19 +29,21 @@
  * URL before returning it from {@link ImageResource#getURL()}.
  */
 public class ImageResourceCell extends AbstractCell<ImageResource> {
+  private static ImageResourceRenderer renderer;

   /**
    * Construct a new ImageResourceCell.
    */
   public ImageResourceCell() {
+    if (renderer == null) {
+      renderer = new ImageResourceRenderer();
+    }
   }

   @Override
   public void render(Context context, ImageResource value, SafeHtmlBuilder  
sb) {
     if (value != null) {
-      SafeHtml html =  
SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(
-          value).getHTML());
-      sb.append(html);
+      sb.append(renderer.render(value));
     }
   }
 }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors