http://gwt-code-reviews.appspot.com/1422812/diff/7001/user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java File user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java (right):
http://gwt-code-reviews.appspot.com/1422812/diff/7001/user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java#newcode72 user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java:72: static final String BINDER_URI = "urn:ui:com.google.gwt.uibinder"; It became part of the scope of this patch when you pasted a copy of the value here. Make UiBinderGenerator#BINDER_URI private. You will find that there are three (3) places that refer to it, all of which can trivially be made to take it as a constructor argument instead. On 2011/05/20 18:27:10, sbrubaker wrote:
On 2011/05/20 17:06:17, rjrjr wrote: > Don't hard code it to the correct value, we won't know if parsers
are
> incorrectly hard coding it themselves. Make it a constructor
argument on
> MockUiBinderWriter.
Can you elaborate on what you are looking for? This value is
hard-coded in
UiBinderGenerator, so any call to UiBinderWriter#isBinderElement
compares to
this exact value. Retooling UiBinderGenerator and all of the places
where
UiBinderGenerator#BINDER_URI is referenced is outside the scope of
this CL. http://gwt-code-reviews.appspot.com/1422812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
