PTAL
http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right): http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode119 user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:119: public void resetWritten() { On 2011/05/16 19:37:47, rjrjr wrote:
No.
Done. http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1360 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1360: fieldManager.rewriteGwtFieldsDeclaration(niceWriter, uiOwnerType.getName()); On 2011/05/16 19:37:47, rjrjr wrote:
I called this out in the first review. What's up with this rewriting
stuff, and
resetting the written status in the field writers? It seems very
wrong. Done. http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1469 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1469: // TODO(sbrubaker): Fix method signature On 2011/05/16 19:37:47, rjrjr wrote:
Stephanie won't be doing these. Shouldn't these issues be fixed now?
Done. http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1479 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1479: // TODO(sbrubaker): Find a better way to remove "asString" On 2011/05/16 19:37:47, rjrjr wrote:
ditto
Done. http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java File user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java (right): http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java#newcode80 user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java:80: "fieldName.setHTML(template.html1().asString());", On 2011/05/16 19:37:47, rjrjr wrote:
This is a very fundamental change of the test. You're no longer
verifying the
output of the parser.
Done. Tests fixed by modifying MockUiBinderWriter instead. http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
