http://gwt-code-reviews.appspot.com/1451801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right):
http://gwt-code-reviews.appspot.com/1451801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode1057 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1057: JsFunctionClusterer clusterer = On 2011/05/23 18:07:01, zundel wrote:
shouldn't this be declared inside the if() block? Anyway, I'm
proposing to move
it inside JsReportGenerationVisitorWithSizeBreakdown anyway.
The clusterer instance is used by the JsIEBlockTextTransformer constructor below that: dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1072: JsIEBlockTextTransformer ieXformer = new JsIEBlockTextTransformer(clusterer); donnelly says: So if it's declared inside the if() block, the scope won't work. Should the JsIEBlockTextTransformer stuff be moved inside JsReportGenerationVisitorWithSizeBreakdown, too, then? zundel: That's a possibility. Is the transform going to be the same before and after the IEExformer change? In that case you could do something general like: v.runTransform(new JsClusterer()); v.runTransform(new JsIEBlockTextTransformer()); v.getJs() v.getSizeBreakdown(); v.getStatementRanges() http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
