http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(left):

http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#oldcode231
dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:231: }
This loop has the same comment as the one  in visit(JInterfaceType, ...)
but written differently.  Since refereces is always false, if
isInstantiated is always false, this rescue becomes a no-op.  We could
either surround this with an if test as below, or just predicate rescue
(JReferenceType, isReferenced, isInstantiated with:

if (type == null || (!isReferenced && !isInstantiated)) { return; }

http://gwt-code-reviews.appspot.com/1443807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to