[gwt-contrib] Re: Introduce PotentialElement to help with the implementation of IsRenderable widgets. (issue1450810)

[rdcastro]

Many thanks for the comments, tbroyer, ptal.


http://gwt-code-reviews.appspot.com/1450810/diff/1/user/src/com/google/gwt/user/client/ui/PotentialElement.java
File user/src/com/google/gwt/user/client/ui/PotentialElement.java
(right):

http://gwt-code-reviews.appspot.com/1450810/diff/1/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode42
user/src/com/google/gwt/user/client/ui/PotentialElement.java:42: e = {};
On 2011/06/02 10:00:32, tbroyer wrote:

var e = {};

otherwise 'e' will be global (and e.__gwt_finishBuild=null won't be

what you're

expecting it to be)

Done.

http://gwt-code-reviews.appspot.com/1450810/diff/1/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode43
user/src/com/google/gwt/user/client/ui/PotentialElement.java:43: e.style
= {};
On 2011/06/02 10:00:32, tbroyer wrote:

Why not:
return {
   style: {},
   setAttribute: function(name, value) { this[name] = value; },
   __gwt_finishBuild = function() {
     this.__gwt_finishBuild = null;
     return o...@com.google.gwt.user.client.ui.UIObject::finishBuild()();
   }
};

I had totally forgotten this syntax even existed. Thanks!

http://gwt-code-reviews.appspot.com/1450810/diff/1/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode45
user/src/com/google/gwt/user/client/ui/PotentialElement.java:45: e[name]
= value;
On 2011/06/02 10:00:32, tbroyer wrote:

Any reason to use 'e' rather than 'this'?

Done.

http://gwt-code-reviews.appspot.com/1450810/diff/1/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode58
user/src/com/google/gwt/user/client/ui/PotentialElement.java:58: return
(PotentialElement) o;
On 2011/06/02 10:00:32, tbroyer wrote:

o.<PotentialElement>cast() ?

Done.

http://gwt-code-reviews.appspot.com/1450810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors