LGTM w/ nits.

http://gwt-code-reviews.appspot.com/1454801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1454801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode1984
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:1984:
boxType.getExactMethod(VALUE_OF, new TypeBinding[] {primitiveType},
scope
I think you have old formatter settings, a while back this changed to
not being a space anymore.  Or maybe they changed again??

http://gwt-code-reviews.appspot.com/1454801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2452
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2452:
private void pushNewExpression(SourceInfo info, AllocationExpression x,
Expression qualifier,
Why is this change needed?  It's not important for the new op and the
varargs array to share the same info identity, you can just make another
one.

http://gwt-code-reviews.appspot.com/1454801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to