http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right):
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java#newcode493 dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java:493: CompilationUnit unit = (CompilationUnit) inputStream.readObject(); On 2011/06/14 01:02:30, scottb wrote:
I wasn't sure if this was kosher, but I considered casting this to CachedCompilationUnit, which would reduce the size of this patch
considerably
since I could only deal with astVersion there. Thoughts?
Why don't you go ahead and do that. http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2797 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2797: public static long getSerializationVersion() { I think we'll need to keep a manual version to 'bump' it in case of emergency, but maybe we could reflection to find all subtypes of JNode, compute some sort of signature as in BytecodeSignatureMaker and use that. Jason says he could use an alternative implementation of that signature for generator result caching. http://gwt-code-reviews.appspot.com/1450816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
