Just a couple of questions on the test
http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/text/shared/UiRenderer.java File user/src/com/google/gwt/text/shared/UiRenderer.java (right): http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/text/shared/UiRenderer.java#newcode21 user/src/com/google/gwt/text/shared/UiRenderer.java:21: * architecture. copy/pasted javadoc should be: Marker interface for SafeHtmlRenderer implementations to be code generated from ui.xml files. http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/elementparsers/RenderablePanelParser.java File user/src/com/google/gwt/uibinder/elementparsers/RenderablePanelParser.java (right): http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/elementparsers/RenderablePanelParser.java#newcode80 user/src/com/google/gwt/uibinder/elementparsers/RenderablePanelParser.java:80: writer.setFieldInitializerAsConstructor(fieldName, type, writer.declareTemplateCall(html, fieldName)); long line http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode287 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:287: JClassType safeHtmlRendererClass = getOracle().findType(SafeHtmlRenderer.class.getName()); Shouldn't this be UiRenderer.class? http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode305 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:305: + " must be set to true to generate a SafeHtmlRenderer"); UiRenderer http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode309 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:309: + " must be set to true to generate a SafeHtmlRenderer"); ditto http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode316 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:316: die(baseClass.getName() + " must implement UiBinder or SafeHtmlRenderer"); ditto http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java File user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java (right): http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java#newcode33 user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java:33: suite.addTestSuite(SafeHtmlRendererTest.class); UiRendererTest, just to give people a better chance of finding it. http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java File user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java (right): http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java#newcode42 user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java:42: public void testSafeHtmlRendererText() { After submitting (let's lock in those gains!), should follow up with test that exercises the i18n stuff, ui:msg and ui:attr http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java#newcode54 user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java:54: assertEquals("<b>This text won't be bold!</b>", I can't figure out where this "won't be bold!" text is coming from. http://gwt-code-reviews.appspot.com/1453812/diff/3001/user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java#newcode59 user/test/com/google/gwt/uibinder/test/client/SafeHtmlRendererTest.java:59: assertEquals(" Hello, ", Should be checking that the stuff in <ui:msg> was processed, and in particular that "<ui:msg>" itself did not get rendered. http://gwt-code-reviews.appspot.com/1453812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
