LGTM

This is a very big change, though. Are you sure you want to rush it into
2.4?


http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
File
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java#newcode474
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java:474:
assert successes.hasNext();
last assert here is silly, the while loop already checked it

http://gwt-code-reviews.appspot.com/1453813/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
(right):

http://gwt-code-reviews.appspot.com/1453813/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode1286
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:1286:
* we have better persistence than the singleton pattern.
This appears twice. Is it useful at all?

http://gwt-code-reviews.appspot.com/1453813/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to