LGTM

http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode251
dev/core/src/com/google/gwt/dev/CompileModule.java:251: for
(CompilationUnit unit : archive.getUnits().values()) {
On 2011/06/23 17:06:21, zundel wrote:
On 2011/06/23 16:50:31, tobyr wrote:
> I think you want to drop this for loop, by changing the above
declaration to:
>
> Set<String> archivedUnits = new
HashSet<String>(archive.getUnits().values());

Unfortunately, I'm not adding the units themselves, I'm adding the
getResourcePath() value from each one.

Oops. Too bad this isn't Scala where it'd be a nice one-liner.

http://gwt-code-reviews.appspot.com/1464803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to