http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java (right):
http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java#newcode139 dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java:139: InputStream in = resource.openContents(); This Util.copy isn't needed to be inside the try catch. http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java File dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java (right): http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java#newcode294 dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java:294: InputStream stream = classSource.openContents(); Util.readStreamAsString doesn't need to be inside try/catch http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/resource/Resource.java File dev/core/src/com/google/gwt/dev/resource/Resource.java (right): http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/resource/Resource.java#newcode84 dev/core/src/com/google/gwt/dev/resource/Resource.java:84: /** This comment is no longer valid, no? It can't return null anymore. But it gives me pause, since it mentions the resource might be invalildated intentionally by its containing resource. Do we know what that's about? Since much of this change is to treat an IOException as a RuntimeException, etc. (not that the current behavior is essentially resulting in that anyway)... http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java File dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java (right): http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java#newcode75 dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java:75: Not sure what this comment is supposed to be saying (and I relealize it's not your mod). 10 Gold stars if you can disambiguate! http://gwt-code-reviews.appspot.com/1461803/diff/6002/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java File user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (right): http://gwt-code-reviews.appspot.com/1461803/diff/6002/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java#newcode204 user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java:204: } catch (IOException iex) { This changes the behavior, from being an NPE to essentially a UnableToCompleteException. I assume that's ok. http://gwt-code-reviews.appspot.com/1461803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
