http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java
File user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java
(right):

http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java#newcode59
user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java:59:
public static void assertGwtSpecificValidatorGenerator(
Would it be possible to factor out common code between this and the next
method? Perhaps, with a boolean determine whether to expect an exception
when calling generator#generate()

http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java#newcode107
user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java:107:
context.finish(logger);
Is the exception expected in generator#generate() or in
context#finish()?

http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java#newcode123
user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java:123:
public static String getFullyQaulifiedModuleName(Class<?> clazz,
Qualified

http://gwt-code-reviews.appspot.com/1467811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to