Changed JsSeedIdOf to hold the seedId (assigned by GenerateJavaScriptAST) instead of lazily retrieving the seedId via JsName earlier (which will be null if it is a not-instantiated class type) Also changed JsToSourceGenerationVisitorWithSizeBreakdown to print the new JsSeedIdOf.
Everything else is mostly the same. I will follow up with a more efficient encoding later, the wins are still very large, no need for perfection. :) On Mon, Jul 11, 2011 at 1:24 PM, <cromwell...@google.com> wrote: > Reviewers: jbrosenberg, > > Description: > Re-roll r10435 > > Changes logic to assign seedIds even to non-instantiable types so that > Foo.class.getName() will return something sensible when > -XdisableClassMetadata > is used. > > > Please review this at http://gwt-code-reviews.appspot.com/1474804/ > > Affected files: > M dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java > M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java > M dev/core/src/com/google/gwt/dev/cfg/StaticPropertyOracle.java > M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java > M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java > M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java > A dev/core/src/com/google/gwt/dev/jjs/ast/JSeedIdOf.java > M dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java > M dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java > M dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java > M dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java > M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java > M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java > M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java > M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java > M > dev/core/src/com/google/gwt/dev/jjs/impl/ImplementClassLiteralsAsFields.java > M dev/core/src/com/google/gwt/dev/jjs/impl/Pruner.java > A dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceGetClassOverrides.java > M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java > M > dev/core/src/com/google/gwt/dev/js/JsSourceGenerationVisitorWithSizeBreakdown.java > M dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java > A dev/core/src/com/google/gwt/dev/js/ast/JsSeedIdOf.java > M dev/core/src/com/google/gwt/dev/js/ast/JsVisitor.java > M > dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java > A > dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/SeedUtil.java > M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitterTest.java > M user/src/com/google/gwt/rpc/linker/ClientOracleLinker.java > M user/src/com/google/gwt/rpc/server/WebModeClientOracle.java > M user/src/com/google/gwt/rpc/server/WebModePayloadSink.java > M user/super/com/google/gwt/emul/java/lang/Class.java > M user/super/com/google/gwt/emul/java/lang/Object.java > M user/test/com/google/gwt/emultest/java/util/ArraysTest.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
