http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java File user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java (right):
http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java#newcode54 user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java:54: return method.invoke(this, args); Is this really related to this patch? What's it fixing? http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode505 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:505: AutoBean<T> created; So when I append the a CarService request context to a DogService context, the car context will know how to make dogs, yes? Are we sure that's desirable? I guess I'm asking if it's a side effect of the fix that is not worth the work of masking, or if you're taking extra effort to make it happen. Presuming this side effect is happening because it needs to happen, we should explicitly test for it. http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode38 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:38: * rechable proxy types. reachable http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode91 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:91: SimpleFooRequest c3 = c2.append(req.simpleFooRequest()); Would be easier to read of the context names reflected their type. barRc1, fooRc1 http://gwt-code-reviews.appspot.com/1499810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
