Nits knitted. Hermes, you still planning to take another look?
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java File user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java#newcode94 user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java:94: int computedCount; On 2011/08/16 18:51:02, hermes wrote:
Can you comment on the purpose of this var?
Done. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java#newcode96 user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java:96: public int computedCount() { On 2011/08/17 15:10:32, rchandia wrote:
getComputedCount()
Done. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode75 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:75: if (fieldName.startsWith("get_")) { On 2011/08/16 18:51:02, hermes wrote:
What if you move "get_" and "build_" to consts?
Done. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode124 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:124: // could this conversion can be moved to FieldWriter? I removed the TODO because I doubt we'll ever do it, and I'm tired of Eclipse getting in a twist whenever I sort members here. On 2011/08/17 15:10:32, rchandia wrote:
"TODO"?
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode301 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:301: source, this, typeOracle); On 2011/08/16 18:51:02, hermes wrote:
move to previous line
Done. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java File user/src/com/google/gwt/uibinder/rebind/FieldReference.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode87 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:87: if (logger != null) { This is a special MonitoredLogger instance, used during validation. It's null when called from HtmlTemplateMethodWriter, which fires after validation has already succeeded. adding a comment On 2011/08/16 18:51:02, hermes wrote:
Seems bad, in which situation logger is null?
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode163 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:163: for (int i = 0; i < left.types.length; i++) { On 2011/08/16 18:51:02, hermes wrote:
I'm seeing this again. Do you think it's worth moving this to a static
method in
some helper class?
Done. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode222 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:222: if (isNumber(leftHandType) && isNumber(rightHandType) && (rightHandType.isPrimitive() != null)) { On 2011/08/16 18:51:02, hermes wrote:
ughh, exploding 100 cols.
Done. http://gwt-code-reviews.appspot.com/1522803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
