Just out of curiosity, does this have to defeat the compiler optimisations? Isn't it known at compile time that those setters will always return the same Style instance? In that sense, from the compiler's point of view, isn't the situation with the setter returning the Style the same as the situation with getStyle() returning the Style?
On 23 August 2011 14:00, Ray Ryan <rj...@google.com> wrote: > No good. This defeats compiler optimizations big time. We don't like void > returns either, but we like big fat slow apps even less. > On Aug 22, 2011 7:50 PM, <larse...@gmail.com> wrote: > > Reviewers: jlabanca, rjrjr, > > > > Description: > > Changes Style to return itself instead of returning void. > > > > issue 6717 > > > > http://code.google.com/p/google-web-toolkit/issues/detail?id=6717 > > > > Please review this at http://gwt-code-reviews.appspot.com/1530803/ > > > > Affected files: > > user/src/com/google/gwt/dom/client/Style.java > > > > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
