http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java#newcode245
dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:245:
exceptionValue, methodName + "(" + args + "), return value: " +
returnJsValue);
Oops, no doubt. Thanks.
On 2011/10/13 00:02:19, tobyr wrote:
Do you want Arrays.toString(args) instead of args?
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java#newcode60
dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java:60: * session's
thread.
On 2011/10/13 00:02:19, tobyr wrote:
Rather than duping the doc, something like:
Equivalent to {@link
#createJavaScriptException(ClassLoader,Object,String)
createJavaScriptException(cl, exception, "")}
Done.
http://gwt-code-reviews.appspot.com/1570803/diff/1/user/src/com/google/gwt/core/client/JavaScriptException.java
File user/src/com/google/gwt/core/client/JavaScriptException.java
(right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/user/src/com/google/gwt/core/client/JavaScriptException.java#newcode191
user/src/com/google/gwt/core/client/JavaScriptException.java:191:
description = description + ": " + getDescription(e);
Description now defaults to "", and a "manual" description can be passed
in to the constructor. getDescription(Object) is a static method that
gets info out of an exception or one or two other kinds of objects. The
init call here ensures that we see both the optional description and the
summary of e.
I'll doc it, or rename the static method to clear things up.
On 2011/10/13 00:02:19, tobyr wrote:
I'm a little confused by what's going on here, since you seem to be
overloading
the meaning of description.
http://gwt-code-reviews.appspot.com/1570803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
