LGTM (as a side note, I always wondered why these events are not in com.google.gwt.event.dom; I believe we could add them there and have the existing ones extend the new ones)
Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this CL to; jgw? jlabanca? fredsa? http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java File user/src/com/google/gwt/user/client/ui/FormPanel.java (right): http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode138 user/src/com/google/gwt/user/client/ui/FormPanel.java:138: private static Type<SubmitHandler> TYPE = new Type<SubmitHandler>(); Isn't this initialization defeating the lazy-init done in getType() ? Seems like the right time to fix this. http://gwt-code-reviews.appspot.com/1582803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors