http://gwt-code-reviews.appspot.com/1601803/diff/1/user/src/com/google/gwt/user/client/ui/ScrollImpl.java File user/src/com/google/gwt/user/client/ui/ScrollImpl.java (right):
http://gwt-code-reviews.appspot.com/1601803/diff/1/user/src/com/google/gwt/user/client/ui/ScrollImpl.java#newcode56 user/src/com/google/gwt/user/client/ui/ScrollImpl.java:56: scrollable.__scrollHandler = scrollHandler; On 2011/11/26 10:36:07, tbroyer wrote:
How about creating static functions (have a look into com.google.gwt.user.client.impl.DOMImplTrident)
I don't see any static methods in DOMImplTrident?
that use window.event.srcElement to get a reference to the
scrollableElem? That way it wouldn't leak and wouldn't need to be "uninstalled". That seems cool.
For the container.onresize, one solution could be to set the
scrollableElem as an expando; e.g. I think Dirk's other leak (issue 1601804 in reitveld) was caused by a parent DOM element having an expando property to one of its children. (AFAIK, would appreciate your comments on that review if I'm wrong.) In this case scrollableElem is the parent, so perhaps a child (container) having an expando to its parent would be okay? http://gwt-code-reviews.appspot.com/1601803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
