LGTM
http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java File src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right): http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java#newcode74 src/com/google/gwt/user/server/rpc/RPCServletUtils.java:74: private static ConcurrentHashMap<String, Charset> CHARSET_CACHE = Just noticed it: should this field be 'final'? http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java#newcode124 src/com/google/gwt/user/server/rpc/RPCServletUtils.java:124: * the default UTF-8 character set will be returned. There probably should be an explicit unit test added to RPCServletUtilsTest; something like: assertSame(RPCServletUtils.CHARSET_UTF8, RPCServletUtils.getCharset(null)); And also add a few tests checking all calls to getCharset return the same instance (it's obvious the tests would be green –though that would have caught the s/encoding/charset/ bug you fixed below, that Rajeev and I hadn't noticed– but they'd be great regression tests) http://gwt-code-reviews.appspot.com/1588803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
