http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode449
dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:449: protected
boolean replaces(JMethod originalMethod) {
?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java#newcode50
dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java:50: public static
int[] splitPointToFragmentMap = null;
I don't think this needs to be static does it? JProgram is usually
passed around as an instance.

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JType.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JType.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JType.java#newcode86
dev/core/src/com/google/gwt/dev/jjs/ast/JType.java:86: protected boolean
replaces(JType originalType) {
Why changed to protected?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode83
dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:83:
whitespace, revert?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode87
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:87:
import com.google.gwt.dev.jjs.ast.JNumericEntry;
Where is JNumericEntity/JsNumberEntity? Forgot to add to patch?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
File dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java#newcode219
dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java:219:
whitespace

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java#newcode192
dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java:192:
//newCall.addArg(program.getLiteralInt(splitPoint));
remove commented out code or does this need to special case if the old
codesplitter is still one??

http://gwt-code-reviews.appspot.com/1631803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to